Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Class Based Components: fix grammar #26441

Closed
wants to merge 3 commits into from
Closed

React: Class Based Components: fix grammar #26441

wants to merge 3 commits into from

Conversation

kol3x
Copy link
Contributor

@kol3x kol3x commented Oct 7, 2023

Because

Fixed spelling from "now a days" to "nowadays"

This PR

  • Changed "now a days" to "nowadays"

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course Content: React Involves the React course labels Oct 7, 2023
@ManonLef
Copy link
Member

ManonLef commented Oct 7, 2023

Thank you. This seems to also contain changes from earlier PR's from you that were already merged. Could it be you have branched from your previous cs_intro_quora_link_fix branch instead of your updated main-branch?, or haven't made a new branch after the last PR?

What you can do is; make sure your fork's main branch is in sync with the original TOP main, then make a new branch from that and make the changes. Or just use the 'improve this lesson on GH' button in the lesson and edit online, which automatically creates a patch branch for you before you can fill out the PR template.

@ManonLef ManonLef self-assigned this Oct 7, 2023
@kol3x
Copy link
Contributor Author

kol3x commented Oct 8, 2023

Thank you. This seems to also contain changes from earlier PR's from you that were already merged. Could it be you have branched from your previous cs_intro_quora_link_fix branch instead of your updated main-branch?, or haven't made a new branch after the last PR?

What you can do is; make sure your fork's main branch is in sync with the original TOP main, then make a new branch from that and make the changes. Or just use the 'improve this lesson on GH' button in the lesson and edit online, which automatically creates a patch branch for you before you can fill out the PR template.

My bad, i guess i did branch from my previous branch. I will go ahead and use "improve this lesson on GH" now.

@kol3x kol3x mentioned this pull request Oct 8, 2023
Merged
7 tasks
@kol3x kol3x closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ManonLef ManonLef

Labels
Content: JavaScript Involves the JavaScript course Content: React Involves the React course Content: Ruby Involves the Ruby course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kol3x @ManonLef